Skip to content

Fix .NET 9 ASP.NET Blazor issues#3064

Merged
mattleibow merged 4 commits intomainfrom
dev/fix-blazor
Nov 25, 2024
Merged

Fix .NET 9 ASP.NET Blazor issues#3064
mattleibow merged 4 commits intomainfrom
dev/fix-blazor

Conversation

@mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Nov 13, 2024

Description of Change

The IJSUnmarshalledObjectReference type has been removed (and we may have only ever needed IJSInProcessObjectReference) but we want to use the new [JSImport] attributes.

There are several changes:

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Copy link
Contributor Author

mattleibow commented Nov 13, 2024

@KameshRajendran
Copy link

KameshRajendran commented Nov 14, 2024

Can you please confirm whether this changes will resolve the below issue?

#3067

@mdubey82
Copy link

When above fix will be available ( #3064 ) Because of this error I am unable to upgrade my project to .net 9

@mattleibow mattleibow merged commit af2f0c1 into main Nov 25, 2024
@mattleibow mattleibow deleted the dev/fix-blazor branch November 25, 2024 18:48
@mattleibow
Copy link
Contributor Author

This fix is now available on the preview feed: 3.118.0-nightly.27

https://aka.ms/skiasharp-eap/index.json

Let me know if this fixes it and I can release.

@Apollo3zehn
Copy link

Yay it works for me, no more errors and rendering output looks fine. Thanks for your great work!

@mdubey82
Copy link

Can anyone please help me understand how to access preview feed: 3.118.0-nightly.27 mentioned above. I googled it but havent found the solution.

@Apollo3zehn
Copy link

Apollo3zehn commented Nov 27, 2024

Like this (https://github.com/nexus-main/nexus/blob/c49e150cdce2d8bde7c43048e62348d61d8dbfcb/Directory.Build.props#L10) but with the URL https://aka.ms/skiasharp-eap/index.json (See README of this repo)

@mattleibow mattleibow added this to the 3.118.0 milestone Nov 27, 2024
mattleibow added a commit that referenced this pull request Nov 27, 2024
* Fix .NET 9 ASP.NET Blazor issues
* Fix the build!
* Fix #3065
The wrong API was used
* fix the yaml

(cherry picked from commit af2f0c1)

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

4 participants