Merged
Conversation
Contributor
Author
|
Can you please confirm whether this changes will resolve the below issue? |
This was referenced Nov 14, 2024
|
When above fix will be available ( #3064 ) Because of this error I am unable to upgrade my project to .net 9 |
1 task
Contributor
Author
|
This fix is now available on the preview feed: Let me know if this fixes it and I can release. |
|
Yay it works for me, no more errors and rendering output looks fine. Thanks for your great work! |
This was referenced Nov 26, 2024
|
Can anyone please help me understand how to access preview feed: 3.118.0-nightly.27 mentioned above. I googled it but havent found the solution. |
|
Like this (https://github.com/nexus-main/nexus/blob/c49e150cdce2d8bde7c43048e62348d61d8dbfcb/Directory.Build.props#L10) but with the URL |
mattleibow
added a commit
that referenced
this pull request
Nov 27, 2024
This was referenced Nov 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The
IJSUnmarshalledObjectReferencetype has been removed (and we may have only ever neededIJSInProcessObjectReference) but we want to use the new[JSImport]attributes.There are several changes:
[JSImport]attributes[JSImport]attribute does not yet support theElementReferencetype, so we have to use the element ID_bl_#(Improve the JavaScript interop code generators to support additional scenarios dotnet/runtime#78455)Moduleobject is no longer available, so we copy the work we did for GL and add Module and GL toSkiaSharpInteropsimd,stto the correctst,simdBugs Fixed
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist