[skia-sync] Merge upstream chrome/m150 bug fixes#4169
Closed
mattleibow wants to merge 1 commit into
Closed
Conversation
Same-milestone sync (m150 → m150): merges 1 new upstream bug-fix commit.
Changes:
- externals/skia: update submodule to merge upstream chrome/m150 bug fix
- [graphite] Use stable collection for static bindings (Dawn backend, Graphite-only)
- Fixes use-after-free bug in DawnGraphicsPipeline binding layout
- No impact on Ganesh (Skia's default GPU backend used by SkiaSharp)
- No C API changes required
- cgmanifest.json: update commitHash and upstream_merge_commit
Build: Linux x64 native build passes, all 5544 tests pass (172 skipped for
hardware reasons).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📦 Try the packages from this PRWarning Do not run these scripts without first reviewing the code in this PR. Step 1 — Download the packages bash / macOS / Linux: curl -fsSL https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.sh | bash -s -- 4169PowerShell / Windows: iex "& { $(irm https://raw.githubusercontent.com/mono/SkiaSharp/main/scripts/get-skiasharp-pr.ps1) } 4169"Step 2 — Add the local NuGet source dotnet nuget add source ~/.skiasharp/hives/pr-4169/packages --name skiasharp-pr-4169More options
Or download manually from Azure Pipelines — look for the Remove the source when you're done: dotnet nuget remove source skiasharp-pr-4169 |
Contributor
|
📖 Documentation Preview The documentation for this PR has been deployed and is available at: 🔗 View Staging Site This preview will be updated automatically when you push new commits to this PR. This comment is automatically updated by the documentation staging workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated upstream bug-fix sync for m150.
Companion skia PR: mono/skia#258
mono/SkiaSharp Sync Summary — chrome/m150 bug fixes
Type
Same-milestone bug-fix sync (m150 → m150)
Changes Made
externals/skia (submodule)
94451aa2839ed8ae5185d25d88784c6185381fa0→caf4799537ffa861286559fa39ff6e99b295f874chrome/m150cgmanifest.json
commitHash: updated to new submodule merge commit SHAupstream_merge_commit: updated to9f330f1704305686dafa9eeef11de77caa5314b1No changes to:
scripts/VERSIONS.txt(version unchanged:4.150.0)scripts/azure-templates-variables.yml(version unchanged)externals/skia/include/c/sk_types.h(SK_C_INCREMENTremains 0)binding/SkiaSharp/SkiaApi.generated.cs(bindings unchanged)Breaking Change Analysis
No breaking changes. The upstream commit is Graphite/Dawn backend only:
DawnGraphicsPipeline.cpp: use-after-free fix for layout pointer stabilityBuild Results
Skipped tests are expected (GPU/hardware tests without display/GPU drivers).
Items Needing Human Attention
None. Routine same-milestone bug-fix sync with no API changes, no breaking changes,
and all tests passing.
Created by skia-upstream-sync.