Open
Conversation
Contributor
|
Thanks for the revamp @umlaeute. I'm talking to the original author here - actually this might not be 100% correct, because the check is performed inside the |
Contributor
Author
|
the original author is @DatanoiseTV (just mentioning them here, so they get notified) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partA of a revamped version of #504, that only includes the "-latomic" fix for arm.
this PR has the "fix typo" commits squashed into a single commit.
also note, that there are more architectures that require linking with
-latomic(though most of them being rather exotic).this is the reason we us the following in the meta-buildsystem for the
giadaDebian package:and then inject the
LIBSinto the CMake invocation.so I personally don't have any special interest in this PR (as it seems to be somewhat over-specific for my needs), and you might just want to use it as a starting point for a more generic solution (e.g. rather than
if(DEFINED ARM)use an optionWITH_ATOMICor somesuch)