Skip to content

Conversation

@hhk7734
Copy link
Member

@hhk7734 hhk7734 commented Jan 18, 2026

No description provided.

@hhk7734 hhk7734 requested a review from a team as a code owner January 18, 2026 11:55
@hhk7734 hhk7734 merged commit 1586704 into main Jan 18, 2026
7 checks passed
@hhk7734 hhk7734 deleted the gotemplate branch January 18, 2026 11:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a style guideline for Go template syntax indentation in YAML files and applies it consistently across e2e test templates. The changes improve code readability by ensuring template directives are properly indented to match their surrounding YAML context.

Changes:

  • Added a new coding guideline in AGENTS.md requiring Go template syntax to be indented to match surrounding code
  • Applied proper indentation to all Go template directives ({{- if ... }}, {{- end }}, etc.) across e2e test template files

Reviewed changes

Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
AGENTS.md Added new guideline under "Go Templates" section specifying indentation requirements for Go template syntax
test/e2e/templates/inference-service-template-common.yaml.tmpl Indented all template directives to align with their YAML context levels
test/e2e/templates/inference-service-prefill.yaml.tmpl Indented template directives to match surrounding YAML structure
test/e2e/templates/inference-service-decode.yaml.tmpl Indented template directives to match surrounding YAML structure
test/e2e/templates/inference-perf-job.yaml.tmpl Indented template directives within shell script and YAML contexts appropriately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant