Fixes #432 (read syscall length is halved for stdin)#433
Open
iridescent1024 wants to merge 1 commit intomortbopet:masterfrom
Open
Fixes #432 (read syscall length is halved for stdin)#433iridescent1024 wants to merge 1 commit intomortbopet:masterfrom
iridescent1024 wants to merge 1 commit intomortbopet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where read syscalls on stdin process only half the buffer provided.
Problem
When a syscall requests N bytes, RIPES currently processes only N/2 bytes.
Root cause
The read loop reduced
lengthRequestedon each iteration while growingmyBuffer. Since the loop condition wasmyBuffer.size() < lengthRequested, both values converged toward the midpoint, causing the loop to terminate after processing only half the requested characters.Fix
Removed the decrement of
lengthRequested.Testing
Related issue
Fixes #432