Open
Conversation
Member
|
In case of' websocket-stream updated to ws' those were useful to check there was breaking changes on protocol-decoder. Like the |
Collaborator
Author
|
Please test it in aedes-protocol-decoder. |
Member
|
Would also decrease coverage, i think we need at least one test that uses decode protocol
Daniel
… On 7 Feb 2020, at 18:05, Gnought ***@***.***> wrote:
Please test it in aedes-protocol-decoder.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
@gnought I suggest to create a dummy protocol decoder test that simply parse data https://github.com/moscajs/aedes/blob/master/lib/client.js#L80 |
Pull Request Test Coverage Report for Build e15ec1ea18585b92aa748d276cd09be64bd7125a-PR-416Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those tests have been moved into aedes-protocol-decoder repo