Skip to content

fix/typings: Remove Readonly<T> from AuthenticateHandler params #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bdchauvette wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fix/typings: Remove Readonly<T> from AuthenticateHandler params #630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/types/aedes.test-d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { expectType } from 'tsd'
import { timingSafeEqual } from 'crypto'
import { Socket } from 'net'
import type {
Aedes,
Expand Down Expand Up @@ -27,8 +28,8 @@ const broker = Server({
callback(new Error('connection error'), false)
}
},
authenticate: (client: Client, username: Readonly<string>, password: Readonly<Buffer>, callback) => {
if (username === 'test' && password === Buffer.from('test') && client.version === 4) {
authenticate: (client: Client, username: string, password: Buffer, callback) => {
if (username === 'test' && timingSafeEqual(password, Buffer.from('test')) && client.version === 4) {
callback(null, true)
} else {
const error = new Error() as AuthenticateError
Expand Down
4 changes: 2 additions & 2 deletions types/instance.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ type PreConnectHandler = (client: Client, packet: ConnectPacket, callback: (erro

type AuthenticateHandler = (
client: Client,
username: Readonly<string>,
password: Readonly<Buffer>,
username: string,
password: Buffer,
done: (error: AuthenticateError | null, success: boolean | null) => void
) => void

Expand Down