Skip to content

docker: add /app to $PATH - #424

Merged
mostlygeek merged 1 commit into
mainfrom
mostlygeek/docker-path
Dec 7, 2025
Merged

docker: add /app to $PATH#424
mostlygeek merged 1 commit into
mainfrom
mostlygeek/docker-path

Conversation

@mostlygeek

@mostlygeek mostlygeek commented Dec 7, 2025

Copy link
Copy Markdown
Owner

Make it so llama-server can be called directly instead of with the full path at /app/llama-server.

Fixes #423
Ref: #233

Summary by CodeRabbit

  • Chores
    • Updated container configuration to ensure application binaries and scripts are properly resolved at runtime.

✏️ Tip: You can customize this high-level summary in your review settings.

Make it so llama-server can be called directly instead of with the full
path at /app/llama-server.

Fixes #423
Ref: #233
@coderabbitai

coderabbitai Bot commented Dec 7, 2025

Copy link
Copy Markdown

Walkthrough

The Dockerfile is modified to add the /app directory to the container's PATH environment variable. This allows binaries located in /app (such as llama-server) to be executed without requiring absolute paths in configuration files.

Changes

Cohort / File(s) Change Summary
Docker container PATH configuration
docker/llama-swap.Containerfile
Adds ENV PATH="/app:${PATH}" to prepend /app directory to the container's PATH, making executables in that directory resolvable by name

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding /app to the container's PATH variable.
Linked Issues check ✅ Passed The code changes directly address the primary objective from issue #423 by adding /app to the container PATH, enabling llama-server to be called by name without absolute path qualification.
Out of Scope Changes check ✅ Passed The pull request contains only the necessary change to the Containerfile for adding /app to PATH, with no unrelated modifications or scope creep.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mostlygeek/docker-path

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b3b0f5 and 97369ef.

📒 Files selected for processing (1)
  • docker/llama-swap.Containerfile (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: ryan-steed-usa
Repo: mostlygeek/llama-swap PR: 368
File: docker/llama-swap.Containerfile:14-20
Timestamp: 2025-10-27T16:04:23.381Z
Learning: In docker/llama-swap.Containerfile, the user/group creation logic intentionally supports adding a non-root user (non-zero UID) to the root group (GID=0) as a valid configuration. This allows flexible UID/GID customization where users can specify only a UID or both UID and GID.
📚 Learning: 2025-10-27T16:04:23.381Z
Learnt from: ryan-steed-usa
Repo: mostlygeek/llama-swap PR: 368
File: docker/llama-swap.Containerfile:14-20
Timestamp: 2025-10-27T16:04:23.381Z
Learning: In docker/llama-swap.Containerfile, the user/group creation logic intentionally supports adding a non-root user (non-zero UID) to the root group (GID=0) as a valid configuration. This allows flexible UID/GID customization where users can specify only a UID or both UID and GID.

Applied to files:

  • docker/llama-swap.Containerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: run-tests
  • GitHub Check: run-tests
🔇 Additional comments (1)
docker/llama-swap.Containerfile (1)

32-35: PATH update correctly exposes /app binaries

Prepending /app to PATH here is the right minimal fix: it makes binaries like llama-server or llama-swap in /app invocable by name for all users in the container, while preserving the base image’s existing PATH. No functional or security regressions apparent.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mostlygeek
mostlygeek merged commit 98879b3 into main Dec 7, 2025
3 checks passed
@mostlygeek
mostlygeek deleted the mostlygeek/docker-path branch January 31, 2026 04:16
mostlygeek added a commit that referenced this pull request May 26, 2026
Make it so llama-server can be called directly instead of with the full
path at /app/llama-server.

Fixes #423
Ref: #233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

llama-server isn't on path from within the docker image

1 participant