Conversation
Move laurus-php from workspace exclude to full workspace member by patching ext-php-rs-clang-sys to remove its `links = "clang"` declaration, which conflicted with clang-sys from laurus-ruby (magnus). - Add patches/ext-php-rs-clang-sys/ with links declaration removed - Add [patch.crates-io] to workspace Cargo.toml - Convert laurus-php/Cargo.toml to use workspace dependencies - Remove standalone laurus-php/Cargo.lock - Update CI to use `cargo build -p laurus-php` instead of `cd laurus-php` - Unify --all-features to --features embeddings-all across all workflows - Add test-php to regression.yml and periodic.yml - Document patch rationale and update procedure in development docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add laurus-php crate providing PHP 8.1+ bindings via ext-php-rs.
Includes full API coverage (Index, Schema, 10 query types, analysis
pipeline), PHPUnit tests (29 tests), examples with Unified Query DSL
search app, and CI/CD for test + build on Linux/macOS.