Skip to content

Refactor FXIOS-14344 [Swift 6 migration] Fixing DependencyHelperMock unit tests warning#31261

Merged
lmarceau merged 2 commits intomainfrom
lm/bootstrapDependencies
Dec 12, 2025
Merged

Refactor FXIOS-14344 [Swift 6 migration] Fixing DependencyHelperMock unit tests warning#31261
lmarceau merged 2 commits intomainfrom
lm/bootstrapDependencies

Conversation

@lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Dec 11, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Fix warning as we discussed in DependencyHelperMock. I'll close this task when this is merged

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@lmarceau lmarceau requested a review from ih-codes December 11, 2025 20:08
@lmarceau lmarceau marked this pull request as ready for review December 11, 2025 20:08
@lmarceau lmarceau requested a review from a team as a code owner December 11, 2025 20:08
@lmarceau lmarceau marked this pull request as draft December 11, 2025 20:27
@lmarceau
Copy link
Contributor Author

Needs more changes before review

@lmarceau lmarceau marked this pull request as ready for review December 11, 2025 21:25
@mobiletest-ci-bot
Copy link

💪 Quality guardian

55 tests files modified. You're a champion of test coverage! 🚀

🧩 Neat Piece

This PR changes 567 lines. It's a substantial update,
but still review-friendly if there’s a clear description. Thanks for keeping things moving! 🚀

🙌 Friday high-five

Thanks for pushing us across the finish line this week! 🙌

✅ Per-file coverage

All changed files meet the threshold of 35.0%.

Generated by 🚫 Danger Swift against 1a84423

Copy link
Collaborator

@ih-codes ih-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a lot of work huh 😆 But this seems right to me!!

@lmarceau lmarceau merged commit 3c409dd into main Dec 12, 2025
8 checks passed
@lmarceau lmarceau deleted the lm/bootstrapDependencies branch December 12, 2025 17:14
@github-actions
Copy link
Contributor

🚀 PR merged to main, targeting version: 147.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants