fix(nimbus): rename event_stream to events_stream, add SourceType enum, add ratios to FeatureSpec#1415
Conversation
661cf23 to
46f33cf
Compare
|
|
|
✅ Jetstream Validation is complete. Check the CI logs for this step for Query SQL and data processing estimates. |
|
This does not block merging, but experiment analysis may timeout and require config changes. |
46f33cf to
0aea57d
Compare
ca9d8b7 to
41057cb
Compare
|
@mikewilli The integration tests clone firefox_desktop.toml from the main branch on GitHub rather than from this PR branch, so they were loading type = "event_stream" while the updated validator now only accepts events_stream — causing the failures. To unblock CI, I've added event_stream as a deprecated alias in SourceType. Once this PR merges, main will have type = "events_stream" in the TOML and the alias can be removed in a follow-up. Both the parser change and the TOML change are in this PR, so they land together. |
mikewilli
left a comment
There was a problem hiding this comment.
Made a couple comments, but everything here looks good.
Did you have something changed in the jetstream/ dir at some point? I'm wondering why the CI put in some messages about experiment analysis, that should only run when jetstream/** stuff is changed.
Also, the integration test issue seems like a bad thing that we should fix (separately), I'll have to think about it. If you're happy with landing this and then updating again afterwards to remove the deprecated event_stream option, then I don't think we need to block this. Thanks!
| [project] | ||
| name = "mozilla-metric-config-parser" | ||
| version = "2026.4.3" | ||
| version = "2026.4.4" |
There was a problem hiding this comment.
You might consider waiting on this. You can have an immediately follow-up to remove the deprecated event_stream option that then pushes a new version.
41057cb to
e1789ed
Compare
yeah my bad did added some changes which were not required |
- Add FeatmonSpec, SourceTableSpec, FeatureSpec classes to parse TOML configs - Add SourceType enum (metrics, events_stream, clients_daily) - Add ratios field to FeatureSpec - Integrate featmon_configs into ConfigCollection.from_github_repo() - Add firefox_desktop.toml with data sources and features - Add featmon/ README and example config - Bump version to 2026.4.4
e1789ed to
6f3e926
Compare
Because
events_streammatches the actual BigQuery table name;event_streamwas inconsistentratioswas referenced in the bigquery-etl query template but had no way to be defined in TOML configsThis commit
event_stream→events_streaminVALID_SOURCE_TYPES,SourceTableSpecdefault, andfirefox_desktop.tomlSourceTypeenum (metrics,events_stream,clients_daily) for type-safe validationratios: list[list[str]]toFeatureSpecso TOML configs can define metric ratiosFeatmonSpec.from_dictto populateratiosfrom config2026.4.4Related: EXP-6732