Closed
Conversation
nebnes
force-pushed
the
feat/s3-server-side-encryption
branch
from
a70c09d to
a984373
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
==========================================
- Coverage 29.81% 29.73% -0.08%
==========================================
Files 49 49
Lines 17556 17539 -17
Branches 8442 8447 +5
==========================================
- Hits 5235 5216 -19
+ Misses 7217 7214 -3
- Partials 5104 5109 +5
☔ View full report in Codecov by Sentry. |
sylvestre
force-pushed
the
feat/s3-server-side-encryption
branch
from
a984373 to
f4f5150
Compare
Xuanwo
approved these changes
Sep 26, 2023
sylvestre
reviewed
Sep 26, 2023
docs/S3.md
Outdated
|
|
||
| If your endpoint requires HTTPS/TLS, set `SCCACHE_S3_USE_SSL=true`. If you don't need a secure network layer, HTTP (`SCCACHE_S3_USE_SSL=false`) might be better for performance. | ||
|
|
||
| Enable server side encryption with `SCCACHE_S3_SERVER_SIDE_ENCRYPTION=true`. |
Collaborator
There was a problem hiding this comment.
Would it be possible to add a link to the Doc to explain what is this encryption? Thanks
Collaborator
There was a problem hiding this comment.
Maybe this docs will be helpful: https://opendal.apache.org/docs/services/s3#server-side-encryption
nebnes
force-pushed
the
feat/s3-server-side-encryption
branch
from
a5e578f to
e54eb3f
Compare
sylvestre
reviewed
Sep 26, 2023
docs/S3.md
Outdated
| If your endpoint requires HTTPS/TLS, set `SCCACHE_S3_USE_SSL=true`. If you don't need a secure network layer, HTTP (`SCCACHE_S3_USE_SSL=false`) might be better for performance. | ||
|
|
||
| Enable server side encryption with s3 managed key (SSE-S3), set `SCCACHE_S3_SERVER_SIDE_ENCRYPTION=true` . | ||
| More details about encryption [here](https://opendal.apache.org/docs/services/s3/#server-side-encryption) and documentation [here](https://docs.rs/opendal/latest/opendal/services/struct.S3.html#method.server_side_encryption_with_s3_key). |
Collaborator
There was a problem hiding this comment.
please add the link on "encryption" and "documentation"
"here" is pretty bad for accessibility / screen reader. thanks
nebnes
force-pushed
the
feat/s3-server-side-encryption
branch
from
e54eb3f to
bf0020e
Compare
nebnes
force-pushed
the
feat/s3-server-side-encryption
branch
from
bf0020e to
46f47cd
Compare
tottoto
added a commit
to tottoto/sccache
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add server side encryption with s3
via env
SCCACHE_S3_SERVER_SIDE_ENCRYPTION=true