Skip to content

Conversation

@dead10ck
Copy link

@dead10ck dead10ck commented Jun 4, 2025

Since #2206, Android fails to compile, due to trying to import a Linux module. Instead, it should import the Android module.

@dead10ck
Copy link
Author

Anything I can do for this PR?

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.91%. Comparing base (a43cade) to head (b331718).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/server.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
- Coverage   71.58%   70.91%   -0.67%     
==========================================
  Files          65       65              
  Lines       36214    35405     -809     
==========================================
- Hits        25923    25109     -814     
- Misses      10291    10296       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dfaure
Copy link

dfaure commented Sep 16, 2025

I just hit the same issue and made a duplicate merge request.

How do we get this merged? It looks like it was hitting old unrelated CI issues on Windows... Can someone rerun CI? Or should I reopen #2442 for that purpose?

@dfaure
Copy link

dfaure commented Sep 16, 2025

@sylvestre ping and hi BTW :-)

@dfaure
Copy link

dfaure commented Sep 17, 2025

@dead10ck can you rebase this on top of current master? it'll trigger CI again

@dfaure
Copy link

dfaure commented Sep 24, 2025

Done in #2442, this one can be closed now.

@sylvestre sylvestre closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants