Skip to content

Conversation

@kornelski
Copy link
Member

sccache's own tests fail when [build] build-dir is set in Cargo's config. This is because cargo_bin() makes no-longer-valid assumptions about Cargo's build directory layout: assert-rs/assert_cmd#257

Cargo has a built-in env var for the path, so cargo_bin() can be removed. The var is set only at build time, not at test run time, which makes env! necessary.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.02%. Comparing base (d4ae480) to head (eb22c95).

Files with missing lines Patch % Lines
tests/helpers/mod.rs 50.00% 1 Missing ⚠️
tests/oauth.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
- Coverage   71.03%   71.02%   -0.01%     
==========================================
  Files          64       64              
  Lines       35317    35318       +1     
==========================================
- Hits        25086    25085       -1     
- Misses      10231    10233       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kornelski kornelski force-pushed the assert-cmd-bad-cargo-bin branch from ce616d4 to edc0915 Compare November 12, 2025 21:39
@kornelski kornelski force-pushed the assert-cmd-bad-cargo-bin branch from edc0915 to eb22c95 Compare November 12, 2025 22:12
@sylvestre sylvestre merged commit 77ce75c into mozilla:main Nov 18, 2025
55 checks passed
@kornelski kornelski deleted the assert-cmd-bad-cargo-bin branch December 15, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants