Add option to initialize mappings wasm via ArrayBuffer#339
Merged
fitzgen merged 2 commits intomozilla:masterfrom May 29, 2018
Merged
Add option to initialize mappings wasm via ArrayBuffer#339fitzgen merged 2 commits intomozilla:masterfrom
fitzgen merged 2 commits intomozilla:masterfrom
Conversation
Pull Request Test Coverage Report for Build 491
💛 - Coveralls |
fitzgen
suggested changes
May 29, 2018
Contributor
fitzgen
left a comment
There was a problem hiding this comment.
Oh wait -- before we merge this, can you add a small test for initializing with an array buffer? Thanks!
Contributor
Author
|
I was going to, but with the existing test tooling, there's no way to write a test for this because Do you have an opinion regarding how browser testing should be done? |
Contributor
|
Bleh, I overlooked that. We would need some kind of headless browser testing setup. If you want to dig into adding that, please be my guest :) In the meantime, we can just merge this. Thanks again! |
Contributor
|
Can you rebase this branch on master? |
7cf7e82 to
6e618f5
Compare
Contributor
Author
|
Just did, thanks! 😄 |
fitzgen
approved these changes
May 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to directly pass in the mappings wasm into
SourceMapConsumer.initialize. This is needed for browser usage without needing to make a request (e.g. needing to work around CSP restrictions).Example
I didn't implement this because it would be a breaking change, but I think a better alternative API might be something like: