How about change the ImageLoader cache save timing

[MrYang614]

Description

I know , ImageLoader will save the resource when onloaded .
In this case :
multiply instance request the same url at one time.

// a.js
class Instance {
    constructor(){
        const texture = new THREE.TextureLoader().load(url)
    }
}

// b.js

for(let i = 0;i<100;i++){
new Instance()
}

the image loaded is a promise, it cause loader can not save resource at the first time, but can return the texture at the first time .

is this better ? save the resource when start load not success Load, we dont need know the request is successful or not .

in old , successful load save cache , error not , but if error will error 100 times ,
in new, start load save cache , even error , just one request , one error

Solution

THREE.core.js line 44226

Alternatives

d

Additional context

No response

[Mugen87]

the image loaded is a promise, it cause loader can not save resource at the first time, but can return the texture at the first time .

I'm afraid this isn't correct. ImageLoader does not use Promises. Instead images are loaded via the Image Web API. That means the loader directly creates an image in load() and returns it to the user:

three.js/src/loaders/ImageLoader.js

Line 69 in ca6d896

const image = createElementNS( 'img' );

three.js/src/loaders/ImageLoader.js

Lines 112 to 114 in ca6d896

	image.src = url;
	return image;

What is true is that ImageLoader does not cache pending requests. Images are only added to the cache after a successful load so if you start loading the same image multiple times, you end up with multiple requests. Is that the issue you are referring to?

[Mugen87]

I wonder why we can't add the image element directly to the cache in onLoad(). This isn't possible in other loaders like FileLoader since the result object only exists after the loading process but in ImageLoader it is available right away.

So the idea is to move Cache.add( url, image ); out of onImageLoad() and place it right before the return statement.

[MrYang614]

I wonder why we can't add the image element directly to the cache in onLoad(). This isn't possible in other loaders like FileLoader since the result object only exists after the loading process but in ImageLoader it is available right away.

So the idea is to move Cache.add( url, image ); out of onImageLoad() and place it right before the return statement.

That's what I'm trying to say ，ImageLoader can cache before onImageload