Merged
Conversation
Mugen87
commented
Jan 6, 2022
Mugen87
commented
Jan 6, 2022
Collaborator
Author
|
BTW: This issue was earlier reported at the forum. It's good to have the |
WestLangley
approved these changes
Jan 6, 2022
Collaborator
Author
|
Merging for further testing. |
Collaborator
Author
|
Updated builds: 3843183 |
elalish
reviewed
Jan 6, 2022
| envMap: cubeRenderTarget2.texture, | ||
| combine: THREE.MultiplyOperation, | ||
| reflectivity: 1 | ||
| roughness: 0, |
Contributor
There was a problem hiding this comment.
I would also recommend using a roughness value > 0 (or several values, or adjustable values). The example only worked before for mirrored reflections; now that it uses actual PMREM, it will also work for other roughness values, so we should demonstrate that to help ensure it does not regress.
elalish
reviewed
Jan 6, 2022
| void main() { | ||
|
|
||
| gl_FragColor = textureCube( envMap, vec3( - vOutputDirection.x, vOutputDirection.yz ) ); | ||
| gl_FragColor = textureCube( envMap, vec3( flipEnvMap * vOutputDirection.x, vOutputDirection.yz ) ); |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #23152
Description
#23152 revealed a small issue in
PMREMGenerator. When working with cube render targets, the same flip logic for px/nx is required like in the material shaders.