Skip to content

LDrawLoader cleanup and docs improvement#23231

Merged
mrdoob merged 9 commits intomrdoob:devfrom
yomboprime:ldraw_cleanup
Jan 14, 2022
Merged

LDrawLoader cleanup and docs improvement#23231
mrdoob merged 9 commits intomrdoob:devfrom
yomboprime:ldraw_cleanup

Conversation

@yomboprime
Copy link
Copy Markdown
Contributor

Related PR: #23173

Description

This PR is just cleanup of some LDrawLoader small details I saw while creating the documentation.

Also added some improvements to the loader docs.

@yomboprime yomboprime requested a review from gkjohnson January 14, 2022 02:02
@mrdoob mrdoob added this to the r137 milestone Jan 14, 2022
Copy link
Copy Markdown
Collaborator

@gkjohnson gkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great to have documentation for the loader. One note is that I am working on a relatively large PR for LDrawLoader to convert the logic to cache the geometry so I'd like to avoid conflicts if you're planning to make other changes. I'll try to retain the modifications you've made here in the upcoming PR, though.

@yomboprime
Copy link
Copy Markdown
Contributor Author

yomboprime commented Jan 14, 2022

Awesome! Great to have documentation for the loader. One note is that I am working on a relatively large PR for LDrawLoader to convert the logic to cache the geometry so I'd like to avoid conflicts if you're planning to make other changes. I'll try to retain the modifications you've made here in the upcoming PR, though.

I'm sorry for the conflicts. I'm not planning to do more PRs to the loader for now.

@mrdoob mrdoob merged commit 69bd229 into mrdoob:dev Jan 14, 2022
@mrdoob
Copy link
Copy Markdown
Owner

mrdoob commented Jan 14, 2022

Thanks!

@joshuaellis joshuaellis mentioned this pull request Jan 19, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants