WebGPURenderer: InstancedMesh Supports Instance Color and Morph Target#27928
Merged
Conversation
sunag
reviewed
Mar 16, 2024
This was referenced Mar 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for instance color and morph target in InstancedMesh within the WebGPURenderer.
Additionally, I have aligned the logic for meshes where a normal attribute is unavailable, opting instead to fall back on to default value
vec3(0,1,0)inNormalNode. Previously, meshes with shading appeared entirely black when the normal attribute was unavailable.Live example:
https://raw.githack.com/renaudrohlinger/three.js/utsubo/feat/morph-instancing/examples/webgpu_instancing_morph.html
This contribution is funded by Utsubo