Examples: Restore look of particle snow demo.#28799
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Jul 3, 2024
Merged
Conversation
Collaborator
Author
|
@RenaudRohlinger I've checked the anamorph demo as well but I don't see a visual difference compared to prod. Do you mind sharing a screenshot that shows the issue? |
Collaborator
Author
|
I have checked now all WebGPU examples and it seems demos with two instances of https://rawcdn.githack.com/mrdoob/three.js/dev/examples/webgpu_camera_logarithmicdepthbuffer.html Browser console is empty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #28784 (comment)
Description
When we have changed the signature from
GaussianBlurNode, we've missed to updatewebgpu_compute_particles_snowso the ctor signature holds the intended values.