Skip to content

TSL: Fix texture matrix reference#28801

Merged
sunag merged 3 commits into
mrdoob:devfrom
sunag:dev-gltf-test
Jul 4, 2024
Merged

TSL: Fix texture matrix reference#28801
sunag merged 3 commits into
mrdoob:devfrom
sunag:dev-gltf-test

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Jul 4, 2024

Related issue: Closes #28758

Description

The matrix reference was lost when the texture was replaced by another one in the reference() node, this ensures that the matrix is ​​updated when the texture is updated.

@sunag sunag added this to the r167 milestone Jul 4, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.4 kB (169.2 kB) 683.4 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.6 kB (111.1 kB) 460.6 kB (111.1 kB) +0 B

@sunag sunag marked this pull request as ready for review July 4, 2024 06:18
@sunag sunag merged commit a6f87ff into mrdoob:dev Jul 4, 2024
@sunag sunag deleted the dev-gltf-test branch July 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGLRenderer replaces WebGPURenderer texture exceptions

1 participant