CubeTextureNode: Support CubeRefractionMapping.#28823
Merged
Mugen87 merged 4 commits intomrdoob:devfrom Jul 6, 2024
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
I push a fix |
424d8de to
38d4eb1
Compare
This was referenced Jul 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #28785
Description
CubeTextureNodecurrently only supportsCubeReflectionMapping. This PR adds support forCubeRefractionMapping.@sunag The code works if you choose
CubeRefractionMappingwhen creating the material. When usingCubeReflectionMappingand switching toCubeRefractionMappingvia the GUI, the material should update whenmaterial.needsUpdateis set totrue. This does not work yet so the mapping does not change. Is there some caching mechanism in place that dees not detect the mapping change of the used cube texture?WebGLRendererchecks the mapping value if an environment map is in place during the program cache key computation so it does not miss this use case.three.js/src/renderers/webgl/WebGLPrograms.js
Line 207 in 6b23527
Side note: For the further development process it would be good to have an example for each material that covers most material features. Something like the
* variationsexamples that we used to have in context ofWebGLRendereror the material browser in the documentation. For now I have addedwebgpu_materials_basicnext to the existingwebgpu_materials_toonandwebgpu_materials_matcap.