Skip to content

ScriptableNode: Fix getCacheKey()#28964

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-getcachekey
Jul 25, 2024
Merged

ScriptableNode: Fix getCacheKey()#28964
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-getcachekey

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Jul 25, 2024

Related issue: Closes #28960

Description

Fix getCacheKey().

@github-actions
Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
684 kB (169.4 kB) 684 kB (169.4 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.9 kB (111.2 kB) 460.9 kB (111.2 kB) +0 B

@sunag sunag marked this pull request as ready for review July 25, 2024 05:35
@sunag sunag merged commit 60a1f06 into mrdoob:dev Jul 25, 2024
@sunag sunag added this to the r167 milestone Jul 25, 2024
@sunag sunag deleted the dev-fix-getcachekey branch July 25, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Examples: webgpu_materials.html is rendering material as black

1 participant