Skip to content

TSL: Remove stack parameter of Fn()#29070

Merged
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-stack-remove
Aug 6, 2024
Merged

TSL: Remove stack parameter of Fn()#29070
sunag merged 1 commit intomrdoob:devfrom
sunag:dev-stack-remove

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Aug 6, 2024

Description

After several improvements in flow control through direct functions, I think we can remove stack as a parameter since it has fallen into disuse.

@sunag sunag changed the title TSL: Remove stack parameter TSL: Remove stack parameter in Fn() Aug 6, 2024
@sunag sunag added this to the r168 milestone Aug 6, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.5 kB) 462 kB (111.5 kB) +0 B

@sunag sunag marked this pull request as ready for review August 6, 2024 01:14
@sunag sunag changed the title TSL: Remove stack parameter in Fn() TSL: Remove stack parameter of Fn() Aug 6, 2024
@sunag sunag merged commit b3d39ff into mrdoob:dev Aug 6, 2024
@sunag sunag deleted the dev-stack-remove branch August 6, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant