Skip to content

GLSLNodeBuilder: Fix GL_ANGLE_multi_draw extension request.#29102

Merged
Mugen87 merged 1 commit intomrdoob:devfrom
cmhhelgeson:fix_get_extension
Aug 9, 2024
Merged

GLSLNodeBuilder: Fix GL_ANGLE_multi_draw extension request.#29102
Mugen87 merged 1 commit intomrdoob:devfrom
cmhhelgeson:fix_get_extension

Conversation

@cmhhelgeson
Copy link
Copy Markdown
Contributor

Related issue: #28952

Description

Properly passes the proper Batched Mesh extension to the vertex stage. Fixes webgpu_mesh_batch sample in WebGL mode.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@Mugen87 Mugen87 added this to the r168 milestone Aug 9, 2024
@Mugen87 Mugen87 merged commit 795e25e into mrdoob:dev Aug 9, 2024
@Mugen87 Mugen87 changed the title WebGPURenderer: Fix WebGLBackend getExtension() GLSLNodeBuilder: Fix GL_ANGLE_multi_draw extension request. Aug 9, 2024
@cmhhelgeson cmhhelgeson deleted the fix_get_extension branch August 9, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants