WebGPUBackend: Fix generateMipmaps() in texture layers#29151
Merged
sunag merged 1 commit intomrdoob:devfrom Aug 16, 2024
Merged
WebGPUBackend: Fix generateMipmaps() in texture layers#29151sunag merged 1 commit intomrdoob:devfrom
generateMipmaps() in texture layers#29151sunag merged 1 commit intomrdoob:devfrom
Conversation
generateMipmaps() in texture layersgenerateMipmaps() in texture layers
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
|
wow, that was quick. I made the change locally in |
Collaborator
Author
|
Maybe be necessary build again three.webgpu.js |
Contributor
|
Ah I understand, since r167 with three.webgpu.js the node system has become a core part. You were right sunag. I just had to rebuild three.webgpu.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Closes #29145