WebGPURenderer: fix occlusion when rendering to a texture with WebGL fallback#29154
Merged
sunag merged 1 commit intomrdoob:devfrom Aug 16, 2024
Merged
WebGPURenderer: fix occlusion when rendering to a texture with WebGL fallback#29154sunag merged 1 commit intomrdoob:devfrom
sunag merged 1 commit intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webgpu_occlusion example is currently broken, the blitFramebuffer operation is included in the scope of the query and produces an incorrect samples_passed count.
Fix this by moving endQuery() before other operations.
Also remove some duplicated consts.