Skip to content

TSL: Rename viewportTopLeft -> viewportUV#29211

Merged
sunag merged 2 commits into
mrdoob:devfrom
sunag:dev-viewport-2
Aug 22, 2024
Merged

TSL: Rename viewportTopLeft -> viewportUV#29211
sunag merged 2 commits into
mrdoob:devfrom
sunag:dev-viewport-2

Conversation

@sunag

@sunag sunag commented Aug 22, 2024

Copy link
Copy Markdown
Collaborator

Related issue: #29162 (comment), #29162 (comment)

Description

  • Renaming viewportTopLeft to viewportUV.
  • Drop z-coordinate of viewportCoordinate
  • Remove viewport + top/bottom-left/right

@sunag sunag added this to the r168 milestone Aug 22, 2024
@github-actions

github-actions Bot commented Aug 22, 2024

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@sunag sunag marked this pull request as ready for review August 22, 2024 18:43
@sunag sunag merged commit f22b8b0 into mrdoob:dev Aug 22, 2024
@sunag sunag deleted the dev-viewport-2 branch August 22, 2024 18:43
@sunag sunag mentioned this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant