Clock, Timer: Drop fallback to Date.now().#29233
Merged
Mugen87 merged 3 commits intomrdoob:devfrom Aug 30, 2024
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
The newer three.js/examples/jsm/misc/Timer.js Line 118 in d7f2d9a While you are at it, please update this module, too. In any event, give us some time to think about unexpected side effects with this removal. |
Collaborator
|
Let's this a try! |
Date.now().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #8112
Description
It's probably a time to drop
Date.nowfallback inClock&Timerclasses, because the support for high resolution timestamp has already been good for years.Browser: https://developer.mozilla.org/en-US/docs/Web/API/Performance/now
Node: https://nodejs.org/docs/latest-v8.x/api/perf_hooks.html#perf_hooks_performance_now (supported since v8.5.0)