WebGPURenderer: Add cube face to readRenderTargetPixelsAsync parameters#29323
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Sep 4, 2024
Merged
WebGPURenderer: Add cube face to readRenderTargetPixelsAsync parameters#29323Mugen87 merged 1 commit intomrdoob:devfrom
readRenderTargetPixelsAsync parameters#29323Mugen87 merged 1 commit intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Sep 4, 2024
Contributor
Author
|
This appears to work with a hacked LightProbeGenerator with the WebGL fallback but the differences in texture coordinates and appear to be causing issues for the WebGPU path. |
Collaborator
|
But that is a separate issue right? The changes to |
Contributor
Author
|
Yes, it works, how the data returned is handled just needs addressing. |
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: comment
Add support reading cube textures to
readRenderTargetPixelsAsync().Not tested with cube textures.