Renderer: clean up#29383
Merged
Merged
Conversation
Mugen87
reviewed
Sep 10, 2024
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
d6a2044 to
5a9fb8e
Compare
Mugen87
reviewed
Sep 10, 2024
5a9fb8e to
ee7931c
Compare
Collaborator
|
In general the PR is okay but I hope it is not taken as an occasion to migrate all code to this style. The previous syntax is totally fine and there is no reason to move everything to destructuring. |
Contributor
Author
|
I had to debug a Three project and I ended up to this file. My IDE highlited some minor changes that can be made via the sourcery plugin so I figured out I might just do a quick PR just to slightly improve the code quality, I don't expect to do more PRs like this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small syntax improvements