Skip to content

Conversation

@aardgoose
Copy link
Contributor

GLSL texelFetch requires integer texel coordinates corrected for coordinate direction using the texture dimensions.

setNode() incorrectly casts the result of uv.setY( ... ) to 'float', attempt to fix that.

@github-actions
Copy link

github-actions bot commented Sep 12, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.83
169.75
685.83
169.75
+0 B
+0 B
WebGPU 832.14
222.98
832.24
223.02
+97 B
+39 B
WebGPU Nodes 831.65
222.86
831.75
222.9
+97 B
+37 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.42
111.53
462.42
111.53
+0 B
+0 B
WebGPU 529.9
142.75
530
142.79
+97 B
+36 B
WebGPU Nodes 486.56
132.61
486.65
132.64
+97 B
+31 B

@Mugen87 Mugen87 added this to the r169 milestone Sep 12, 2024
@sunag sunag merged commit 8ebbbf2 into mrdoob:dev Sep 17, 2024
@aardgoose aardgoose deleted the texel branch September 18, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants