Skip to content

NodeBuilder: Introduce addFlowCodeHierarchy() / NodeBlock#29495

Merged
sunag merged 3 commits intomrdoob:devfrom
sunag:dev-tsl-cond-rev
Sep 25, 2024
Merged

NodeBuilder: Introduce addFlowCodeHierarchy() / NodeBlock#29495
sunag merged 3 commits intomrdoob:devfrom
sunag:dev-tsl-cond-rev

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Sep 25, 2024

Related issue: #29489

Description

Improves support for code block and fixes issues related to conditionals.

@sunag sunag added this to the r169 milestone Sep 25, 2024
@github-actions
Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 687.46
170.22
687.46
170.22
+0 B
+0 B
WebGPU 839.72
225.2
840.46
225.41
+745 B
+212 B
WebGPU Nodes 839.23
225.08
839.97
225.29
+745 B
+210 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 463.24
111.86
463.24
111.86
+0 B
+0 B
WebGPU 533.78
143.98
534.61
144.23
+835 B
+251 B
WebGPU Nodes 490.12
133.72
490.96
133.98
+835 B
+255 B

@sunag sunag marked this pull request as ready for review September 25, 2024 20:42
@sunag sunag merged commit 46de256 into mrdoob:dev Sep 25, 2024
@sunag sunag deleted the dev-tsl-cond-rev branch September 25, 2024 20:53
@mrdoob
Copy link
Copy Markdown
Owner

mrdoob commented Sep 26, 2024

Do we still need temp()?

@sunag sunag mentioned this pull request Sep 28, 2024
@sunag
Copy link
Copy Markdown
Collaborator Author

sunag commented Sep 28, 2024

Do we still need temp()?

Certainly not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants