Skip to content

WebGPURenderer: remove obsolete code#29596

Merged
RenaudRohlinger merged 1 commit intomrdoob:devfrom
aardgoose:render-list
Oct 9, 2024
Merged

WebGPURenderer: remove obsolete code#29596
RenaudRohlinger merged 1 commit intomrdoob:devfrom
aardgoose:render-list

Conversation

@aardgoose
Copy link
Copy Markdown
Contributor

RenderList.getLightsNode() has no callers and calls a LightsNode method that has been removed.
Remove obsolete method.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 811.56
218.6
811.49
218.59
-68 B
-14 B
WebGPU Nodes 811.07
218.47
811
218.46
-68 B
-14 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.78
144.59
535.71
144.58
-68 B
-17 B
WebGPU Nodes 491.89
134.34
491.83
134.32
-68 B
-18 B

@RenaudRohlinger RenaudRohlinger added this to the r170 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants