ScriptableNode: Rename global to ScriptableNodeResources#29736
Merged
sunag merged 3 commits intomrdoob:devfrom Oct 25, 2024
Merged
ScriptableNode: Rename global to ScriptableNodeResources#29736sunag merged 3 commits intomrdoob:devfrom
global to ScriptableNodeResources#29736sunag merged 3 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Oct 24, 2024
sunag
changed the title
global -> ScriptableNodeResources
sunag
changed the title
global -> ScriptableNodeResourcesglobal to ScriptableNodeResources
This was referenced Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: NA
Description
When running a multiplatform React Native app on the web, the bundler declares a local variable
globalwhich exists to increase compatibility with different ecosystems such as react-native ios/android or node. I have renamed theglobalvariable inside ScriptableNode.js so that locally it is simplylocalGlobal. The export remains the same however, so it should have no downstream implications.