Manual: Fix loaderArrayLoadRE regex to allow spaces before square bracket.#29820
Merged
Conversation
Mugen87
approved these changes
Nov 6, 2024
Mugen87
changed the title
loaderArrayLoadRE regex to allow spaces before square bracket.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #29819
Description
The regex used to detect and re-write URLs in the manual when loading an array did not account for any spaces between the opening bracket and the opening square bracket. As a result these would not be rewritten and failed to load when viewing the example on the manual page it's embedded.
This PR simply expands the regex to match against zero or more spaces, resolving the issue.