Skip to content

UniformArrayNode: Fix getNodeType()#30058

Merged
sunag merged 6 commits intomrdoob:devfrom
sunag:dev-uniformarray-fix
Dec 7, 2024
Merged

UniformArrayNode: Fix getNodeType()#30058
sunag merged 6 commits intomrdoob:devfrom
sunag:dev-uniformarray-fix

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Dec 7, 2024 •
edited
Loading

Related issue: #30051

Description

Fix getNodeType() after paddedType for auto-conversion.

@sunag sunag added this to the r172 milestone Dec 7, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 7, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.11
78.98		 339.11
78.98		 +0 B
+0 B
WebGPU 485.6
134.82		 485.65
134.83		 +54 B
+13 B
WebGPU Nodes 485.07
134.72		 485.12
134.73		 +54 B
+14 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465
112.04		 465
112.04		 +0 B
+0 B
WebGPU 554.99
150.26		 555.05
150.28		 +54 B
+17 B
WebGPU Nodes 510.87
139.97		 510.93
140		 +54 B
+31 B

@sunag sunag marked this pull request as ready for review December 7, 2024 18:00
@sunag sunag merged commit 1b6a704 into mrdoob:dev Dec 7, 2024
@sunag sunag deleted the dev-uniformarray-fix branch December 7, 2024 18:44
@Methuselah96 Methuselah96 mentioned this pull request Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r172

Development

Successfully merging this pull request may close these issues.

1 participant

@sunag