Skip to content

WebGPURenderer: Fix blending opacity in shadows#30081

Merged
sunag merged 4 commits into
mrdoob:devfrom
sunag:dev-shadow-rev
Dec 10, 2024
Merged

WebGPURenderer: Fix blending opacity in shadows#30081
sunag merged 4 commits into
mrdoob:devfrom
sunag:dev-shadow-rev

Conversation

@sunag

@sunag sunag commented Dec 9, 2024

Copy link
Copy Markdown
Collaborator

Related issue: #28973

Description

Fix blending opacity in shadows.

Before After
image image

@sunag sunag added this to the r172 milestone Dec 9, 2024
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01
339.21
79.01
+0 B
+0 B
WebGPU 485.99
134.91
486.02
134.92
+33 B
+11 B
WebGPU Nodes 485.45
134.81
485.49
134.82
+33 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06
465.1
112.06
+0 B
+0 B
WebGPU 555.39
150.39
555.42
150.41
+33 B
+17 B
WebGPU Nodes 511.24
140.09
511.27
140.11
+33 B
+18 B

@sunag sunag marked this pull request as ready for review December 10, 2024 00:42
@sunag sunag merged commit dc34412 into mrdoob:dev Dec 10, 2024
@sunag sunag deleted the dev-shadow-rev branch December 10, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant