Skip to content

Node: fix some types#30323

Merged
Mugen87 merged 4 commits into
mrdoob:devfrom
s-rigaud:node-types
Jan 14, 2025
Merged

Node: fix some types#30323
Mugen87 merged 4 commits into
mrdoob:devfrom
s-rigaud:node-types

Conversation

@s-rigaud
Copy link
Copy Markdown
Contributor

Description

Fix some typing issues in the documentation of src/nodes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 14, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.53
79.09
339.53
79.09
+0 B
+0 B
WebGPU 491.01
136.43
491.01
136.43
+0 B
+0 B
WebGPU Nodes 490.47
136.32
490.47
136.32
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.15
465.42
112.15
+0 B
+0 B
WebGPU 561.58
152.14
561.58
152.14
+0 B
+0 B
WebGPU Nodes 516.97
141.71
516.97
141.71
+0 B
+0 B

@Mugen87 Mugen87 added this to the r173 milestone Jan 14, 2025
Comment thread src/renderers/common/Background.js
Comment thread src/materials/nodes/NodeMaterial.js Outdated
@Mugen87 Mugen87 merged commit a34d43c into mrdoob:dev Jan 14, 2025
@s-rigaud s-rigaud deleted the node-types branch January 22, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants