Skip to content

SpriteNodeMaterial: Fix scaleNode type convertion#30545

Merged
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-material
Feb 17, 2025
Merged

SpriteNodeMaterial: Fix scaleNode type convertion#30545
sunag merged 1 commit into
mrdoob:devfrom
sunag:dev-fix-material

Conversation

@sunag
Copy link
Copy Markdown
Collaborator

@sunag sunag commented Feb 17, 2025

Fixes: #30539

Description

Fix scaleNode type convertion of SpriteNodeMaterial.

@sunag sunag added this to the r174 milestone Feb 17, 2025
@sunag sunag marked this pull request as ready for review February 17, 2025 15:18
@github-actions
Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.36
78.33
336.36
78.33
+0 B
+0 B
WebGPU 518.85
144
518.85
144
+0 B
+1 B
WebGPU Nodes 518.32
143.88
518.32
143.88
+0 B
+1 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.35
112.17
465.35
112.17
+0 B
+0 B
WebGPU 590.68
159.95
590.68
159.95
+0 B
+2 B
WebGPU Nodes 545.99
149.43
545.99
149.43
+0 B
+0 B

@sunag sunag merged commit 82c9bb0 into mrdoob:dev Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SpriteNodeMaterial scaleNode accept vec2

2 participants