Conversation
Owner
Author
|
@Mugen87 Does this run slower in your machine too? |
Collaborator
|
Both run with 60 FPS on the macMini and Pixel 8a 🎉 . |
Mugen87
reviewed
Jul 31, 2025
Mugen87
approved these changes
Jul 31, 2025
Owner
Author
|
Lolz, just realized there are some missing objects when looking through the lense 😅 |
Mugen87
reviewed
Aug 3, 2025
|
|
||
| if ( object.material ) { | ||
|
|
||
| if ( object.material.name === 'Lense_Casing' ) { |
Collaborator
There was a problem hiding this comment.
Maybe reverting this addition due to #31539 (comment)?
Yes, the previous look was also not physically correct but the missing objects when looking through the lens makes the scene look broken^^.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Spent some time trying to make this example look prettier.
I made it so the roughness pass modulates the ssr.
Ideally we would be blurring the reflection but this gives a good enough result for now.
Also fixed the lens transparency:
Screen.Recording.2025-07-31.at.6.42.28.PM.mov
Current: https://rawcdn.githack.com/mrdoob/three.js/dev/examples/webgpu_postprocessing_ssr.html
New: https://rawcdn.githack.com/mrdoob/three.js/examples-ssr/examples/webgpu_postprocessing_ssr.html