TSL: Do not auto-generate tangent attribute.#32220
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
|
It would be good if we had an automatic alternative for tangents soon, this should make things easier since most node systems and 3D software do this, and since most models don't have tangents exported, it would still be compatible with alternatives like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #32198.
Description
Computing a tangent attribute when building nodes corrupts the cache key and leads to confusing behavior like described in #32198. For a more consistent behavior, it's better to let the application compute tangent vectors if they are missing in geometry data. Developers might prefer to use
BufferGeometryUtils.computeMikkTSpaceTangents()anyway for tangent computation.Removing the auto-generation triggers below warning if tangent are missing so users should be informed about what's going on: