NodeBuilders: Unifies uniform groups of different shader stages#32534
Merged
sunag merged 2 commits intomrdoob:devfrom Dec 15, 2025
Merged
NodeBuilders: Unifies uniform groups of different shader stages#32534sunag merged 2 commits intomrdoob:devfrom
sunag merged 2 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Author
|
This will make the buffers larger, making partial buffer updates more important, which can be done until the end of the release. |
This was referenced Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #32243
Description
The goal is to unify the uniform groups from different shader stages into a single one shared, thus avoiding updating some buffers in two different places. The main focus of the unification is to facilitate the sharing of groups between similar objects, since this would be more complicated if they were separated between vertex binding groups and fragment shaders.
This is still part of the update that is being done in #32243