Quaternion - Support extrapolation in slerp methods#32541
Merged
mrdoob merged 2 commits intomrdoob:devfrom Dec 13, 2025
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
commented
Dec 13, 2025
| const a = new Quaternion( x, y, z, w ); | ||
| const b = new Quaternion( - x, - y, - z, - w ); | ||
| const a = new Quaternion( x, y, z, w ).normalize(); | ||
| const b = new Quaternion( w, x, y, z ).normalize(); |
Collaborator
Author
There was a problem hiding this comment.
This test case was failing.
A quaternion and its negation represent the same rotation, so the equality test used here is invalid.
For now, I made an arbitrary change that passes the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #31875 (comment).
Prior to #31875, the three.js quaternion slerp methods allowed values of the parameter
toutside of the interval[0, 1].This PR restores the former behavior.