RapierPhysics: Fix dynamic import Vite warning#32565
Merged
Conversation
mrdoob
force-pushed
the
claude/fix-threejs-32560-WzE01
branch
from
ef86e24 to
f5bcc86
Compare
Add @vite-ignore comment to suppress Vite's "dynamic import cannot be analyzed" warning. The import loads Rapier from a CDN at runtime, which cannot be statically analyzed by design. Fixes #32560
mrdoob
force-pushed
the
claude/fix-threejs-32560-WzE01
branch
from
f5bcc86 to
d242556
Compare
mrdoob
changed the title
Contributor
|
When I check the potential fix from AI, it seems like we need to fix one more file? https://github.com/mrdoob/three.js/pull/32566/files |
Owner
Author
|
Yes, can you do a PR to fix Jolt following the fix for Rapier here? |
Owner
Author
|
Also, make sure the PR title and description are descriptive. |
Owner
Author
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #32560
Description
Add @vite-ignore comment to suppress Vite's "dynamic import cannot be analyzed" warning. The import loads Rapier from a CDN at runtime, which
cannot be statically analyzed by design.