Skip to content

AnimationAction: Preserve interpolant settings on action creation.#33033

Merged
Mugen87 merged 2 commits intomrdoob:devfrom
gigajuad:fix/bezier-interpolant-settings
Feb 20, 2026
Merged

AnimationAction: Preserve interpolant settings on action creation.#33033
Mugen87 merged 2 commits intomrdoob:devfrom
gigajuad:fix/bezier-interpolant-settings

Conversation

@gigajuad
Copy link
Contributor

@gigajuad gigajuad commented Feb 20, 2026

Fixed #33032

Description

When using InterpolateBezier with the animation system, the BezierInterpolant ends up doing linear interpolation because the AnimationAction constructor overwrites interpolant.settings with a shared ending-behavior object, wiping out the inTangents and outTangents data.

The interpolant is created correctly with tangent data, but by the time it runs, that data is gone.

To fix, the AnimationAction constructor is slightly modified to append the track.settings instead of replacing it.

@github-actions
Copy link

github-actions bot commented Feb 20, 2026

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 359.15
85.24
359.15
85.24
+0 B
+0 B
WebGPU 623.55
173.47
623.55
173.47
+0 B
+0 B
WebGPU Nodes 622.13
173.21
622.13
173.21
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 490.87
119.65
490.87
119.65
+0 B
+0 B
WebGPU 697.03
188.44
697.03
188.44
+0 B
+0 B
WebGPU Nodes 646.24
175.82
646.24
175.82
+0 B
+0 B

@Mugen87 Mugen87 added this to the r184 milestone Feb 20, 2026
@Mugen87 Mugen87 changed the title fix : added fix to preserve track.settings on action creation, ensuring bezier interpolant functionality AnimationAction: Preserve interpolant settings on action creation. Feb 20, 2026
Update comment.
@Mugen87 Mugen87 merged commit ac88a8c into mrdoob:dev Feb 20, 2026
10 checks passed
@sunag sunag mentioned this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG : BezierInterpolant silently falls back to linear — mixer overwrites tangent settings

2 participants