AnimationAction: Preserve interpolant settings on action creation.#33033
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Feb 20, 2026
Merged
AnimationAction: Preserve interpolant settings on action creation.#33033Mugen87 merged 2 commits intomrdoob:devfrom
Mugen87 merged 2 commits intomrdoob:devfrom
Conversation
…terpolant) upon action creation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Feb 20, 2026
Update comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #33032
Description
When using
InterpolateBezierwith the animation system, theBezierInterpolantends up doing linear interpolation because theAnimationActionconstructor overwritesinterpolant.settingswith a shared ending-behavior object, wiping out theinTangentsandoutTangentsdata.The interpolant is created correctly with tangent data, but by the time it runs, that data is gone.
To fix, the AnimationAction constructor is slightly modified to append the track.settings instead of replacing it.