AnimationAction: Fix timeScale reversal jump.#33035
Merged
Mugen87 merged 1 commit intomrdoob:devfrom Feb 21, 2026
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #19151.
Description
The PR fixes a long-standing bug in
AnimationActionthat happens when the time scale of the animation mixer is reversed during the first run of looped animations.I've tried to fix this multiple times in the past but wasn't sure about the real root cause. With the help of Claude 4.6, this should be resolved. Claude required multiple attempts but eventually found the root cause in an
elsebranch where a member wasn't correctly updated.The test code from #19151 now behaves correctly and the animation examples should also work as before (tested locally). I think it's worth giving this fix a try!