Updated to RUST 2024 & rustc 1.88.0-nightly#16
Open
isoux wants to merge 4 commits intomrgian:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Gian!
... I prefer it without external crates too ...
I managed to implement your Mutex everywhere and even added it to the files where you had warnings:
//Warning! Mutable static here
//TODO: Implement a mutex to get safe access to this
It wasn't as difficult as it seemed at first. The key to the solution is in the raw pointers. So to access the static mut XYZ like there:
FAT.acquire().list_entries();
FAT.free();
Now you must write like this:
((&raw mut FAT)).acquire().list_entries();
((&raw mut FAT)).free();
Accordingly, I had to adjust and move some unsafe {} ...
The code now compiles and runs without errors or warnings on the latest nightly build 1.88 rust 2024
Isoux