fix sass tilde importer partials support#193
Merged
mrmckeb merged 3 commits intomrmckeb:mainfrom Feb 18, 2023
Merged
Conversation
mrmckeb
reviewed
Jan 31, 2023
Owner
mrmckeb
left a comment
mrmckeb
left a comment
There was a problem hiding this comment.
Thanks for this! Are you able to add a test or two to cover the change here?
Contributor
Author
|
So I had taken a look at trying to add a test to cover this, but I didn't see any examples of modules or dependent modules that were already a part of the package.json that I could use. Would it be ok for me to loop in, for example, sass-mq as a devDependency to accomplish this, or is there a better way to mock it maybe? Maybe I could split out the functionality of |
dennispg
force-pushed
the
sass-tilde-importer-fix
branch
from
6bc9ae0 to
d49629b
Compare
dennispg
force-pushed
the
sass-tilde-importer-fix
branch
from
d49629b to
15dee92
Compare
Contributor
Author
|
@mrmckeb I've gone ahead and done a significant refactoring here, and split out the resolve bits into it's own function so that tests can be written against it directly. And I added the relevant tests as well. |
Contributor
Author
|
Also I removed the part where it was walking the file directory tree.. I don't think that was accomplishing what it was expected to, and was just not necessary. |
mrmckeb
approved these changes
Feb 18, 2023
Owner
|
Thanks for this, I'm working through some refactoring today/tomorrow, but will release this over the course of the weekend. |
calvellido
referenced
this pull request
in arrow-kt/arrow-website
Feb 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules) | [`4.1.1` -> `4.2.2`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.1.1/4.2.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mrmckeb/typescript-plugin-css-modules</summary> ### [`v4.2.2`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.2) [Compare Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.1...v4.2.2) **Bug fixes:** - Fix potentially fatal CSS classname regexp bug ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/205](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/205)). **Full changelog**: mrmckeb/typescript-plugin-css-modules@v4.2.1...v4.2.2 ### [`v4.2.1`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.1) [Compare Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.0...v4.2.1) **Bug fixes:** - Correct `additionalData` typo ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/204](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/204)). **Full changelog**: mrmckeb/typescript-plugin-css-modules@v4.2.0...v4.2.1 ### [`v4.2.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v4.2.0) [Compare Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.1.1...v4.2.0) **New features:** - Add Less support for `goToDefinition` ([@​mariusGundersen](https://togithub.com/mariusGundersen), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/192](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/192)). - Add `additionalData` option to append text content to files before they're processed ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/203](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/203)). **Bug fixes:** - Fix Sass tilde importer partial support ([@​dennispg](https://togithub.com/dennispg), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/193](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/193)). **Other:** - Remove unsupported `postcss-*` packages ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/201](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/201)). - Improve `goToDefinition` documentation and add additional tests ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/202](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/202)). **New contributors** - [@​mariusGundersen](https://togithub.com/mariusGundersen) made their first contribution in [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/192](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/192) - [@​dennispg](https://togithub.com/dennispg) made their first contribution in [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/193](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/193) **Full changelog**: mrmckeb/typescript-plugin-css-modules@v4.1.1...v4.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0Ni4xIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a bug when importing partial sass files from
node_moduleswhich happen to have their basename exist also in some part of the dirname.For example,
@import '~sass-mq/mq';should resolve tonode_modules/sass-mq/_mq.scssbut instead is looking fornode_modules/sass-_mq/mq.scss.