Conversation
Closed
5 tasks
lianapache
reviewed
Mar 11, 2023
mrmckeb
force-pushed
the
196-ts-5-compatibility
branch
from
9792959 to
b515389
Compare
lianapache
approved these changes
Mar 11, 2023
jakebailey
reviewed
Mar 11, 2023
| }, | ||
| }); | ||
|
|
||
| const languageService = createLanguageService(languageServiceHostProxy); |
Contributor
There was a problem hiding this comment.
Should this be using the ts parameter? If tsserver is run via VS Code, it may not match the version in node_modules.
Contributor
There was a problem hiding this comment.
(Generally I'd suggest type importing only for plugins to avoid this mismatch)
Contributor
There was a problem hiding this comment.
Also, you probably only want to import from tsserverlibrary, as it's a different bundle entirely.
Closed
calvellido
referenced
this pull request
in arrow-kt/arrow-website
Mar 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [typescript-plugin-css-modules](https://togithub.com/mrmckeb/typescript-plugin-css-modules) | [`4.2.3` -> `5.0.0`](https://renovatebot.com/diffs/npm/typescript-plugin-css-modules/4.2.3/5.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mrmckeb/typescript-plugin-css-modules</summary> ### [`v5.0.0`](https://togithub.com/mrmckeb/typescript-plugin-css-modules/releases/tag/v5.0.0) [Compare Source](https://togithub.com/mrmckeb/typescript-plugin-css-modules/compare/v4.2.3...v5.0.0) **Breaking changes:** - TypeScript 4.x is now the minimum supported version ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)). **New features:** - Added support for TypeScript 5.x ([@​mrmckeb](https://togithub.com/mrmckeb), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/211](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/211)). **Bug fixes:** - Fixed use of non-init provided TypeScript lib and move to consistent `server` imports ([@​jakebailey](https://togithub.com/jakebailey), [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213)). **New contributors:** - [@​jakebailey](https://togithub.com/jakebailey) made their first contribution in [https://github.com/mrmckeb/typescript-plugin-css-modules/pull/213](https://togithub.com/mrmckeb/typescript-plugin-css-modules/pull/213). **Full changelog:** mrmckeb/typescript-plugin-css-modules@v4.2.3...v5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/arrow-kt/arrow-website). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for TypeScript 5.x.
Once merged, this will be released as a beta for further testing.